Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 594: remove modules from the list that are already gone or deprecated #2274

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

brettcannon
Copy link
Member

No description provided.

@@ -632,9 +571,6 @@ Discussions
of modules like ``imp`` until Python 3.10. Version 3.8 will be released
shortly before Python 2 reaches end-of-life. A delay reduced churn for
users that migrate from Python 2 to 3.8.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettcannon Just to make sure, you still want to keep this one?

Copy link
Member

@AA-Turner AA-Turner Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imp is already deprecated (https://docs.python.org/3/library/imp.html), and slated for removal in Python 3.12 (this doesn't seem to be in the docs though, so a issue might need to be raised). edit: see bpo-43720

https://github.com/python/cpython/blob/072f4a473e861c6c987650f08990c0ed1f76715f/Lib/imp.py#L31-L34

A

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imp is already deprecated (https://docs.python.org/3/library/imp.html)

Yeah, we're both aware 🙂 In this PR, @brettcannon removed imp from the list above for that reason; I was just checking in case he wanted to remove it here as well.

this doesn't seem to be in the docs though, so a issue might need to be raised).

At the top:

Deprecated since version 3.4: The imp module is deprecated in favor of importlib.

Copy link
Member

@AA-Turner AA-Turner Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! Sorry for the noise then.

At the top

That doesn't note the actual version of the (pending) removal, though. Rather minor, regardless.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants