Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 678: add post-history, minor tweaks following discussion #2294

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Feb 2, 2022

Following the post on python-dev which requested comments to this Discuss thread, I've updated PEP 678 with Post-History and some minor clarifications following that discussion.

I believe that after this PR is merged, the PEP is ready for consideration by the Steering Council.

My deep thanks again to everyone who has helped me through this, especially the many thoughtful commenters, those who proof-read and contributed fixes, and to Irit for her support and sponsorship throughout 🙏

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Zac for your work on this PEP.

Once the discussion has been idle for a week or so, this indeed looks ready to be submitted to the SC (you do that by creating an issue on the SC tracker, such as this one python/steering-council#98).

pep-0678.rst Outdated Show resolved Hide resolved
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A couple small copyedits, and one general procedural comment.

Also, please add a link to the Discourse thread to the header between Sponsor and Status, as required by PEP 1 and PEP 12, and which makes it far more accessible for users coming across the PEP now or in the future to find. I.e.:

Discussions-To: https://discuss.python.org/t/13374

pep-0678.rst Outdated Show resolved Hide resolved
pep-0678.rst Outdated Show resolved Hide resolved
@@ -8,7 +8,7 @@ Content-Type: text/x-rst
Requires: 654
Created: 20-Dec-2021
Python-Version: 3.11
Post-History:
Post-History: 2022-01-27
Copy link
Member

@CAM-Gerlach CAM-Gerlach Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no formal requirement I can find in PEP-0001, but less than a week of discussion and review between announcing/opening a discussion thread for a PEP and submitting it for final consideration for the SC seems a little short, at least to me...

@AA-Turner
Copy link
Member

Thanks @Zac-HD

Please could you line wrap to 79 per PEP 12 in a followup PR before submission to the Council.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants