Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 7: prefer static inline functions #2315

Merged
merged 1 commit into from
Feb 8, 2022
Merged

PEP 7: prefer static inline functions #2315

merged 1 commit into from
Feb 8, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 8, 2022

No description provided.

@vstinner
Copy link
Member Author

vstinner commented Feb 8, 2022

Apply SC's request related to the PEP 670.

@vstinner
Copy link
Member Author

vstinner commented Feb 8, 2022

cc @encukou

hugovk
hugovk reviewed Feb 8, 2022
View reviewed changes
pep-0007.txt Outdated Show resolved Hide resolved
@vstinner
Copy link
Member Author

vstinner commented Feb 8, 2022

Not sure we should mention PEP 670 at all, given that the PEP as a whole has not yet been decided on.

It's half accepted and the decision comes from there. No?

@vstinner vstinner merged commit c0fc47a into python:main Feb 8, 2022
@vstinner vstinner deleted the pep7_static_inline branch February 8, 2022 17:45
@vstinner
Copy link
Member Author

vstinner commented Feb 8, 2022

Ok, I merged my PR.

@vstinner
Copy link
Member Author

vstinner commented Feb 8, 2022

Thanks for the reviews!

@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

@hugovk hugovk hugovk left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@warsaw warsaw Awaiting requested review from warsaw

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @JelleZijlstra @hugovk @erlend-aasland @the-knights-who-say-ni