Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 683: Implement minor typographical changes #2342

Merged
merged 4 commits into from
Feb 25, 2022
Merged

PEP 683: Implement minor typographical changes #2342

merged 4 commits into from
Feb 25, 2022

Conversation

JelleZijlstra
Copy link
Member

Some things I noticed while reading through #2341.

@JelleZijlstra
Minor PEP 683 changes
18a4177 
Some things I noticed while reading through #2341.
JelleZijlstra
JelleZijlstra commented Feb 19, 2022
View reviewed changes
pep-0683.rst Outdated Show resolved Hide resolved
@CAM-Gerlach CAM-Gerlach changed the title Minor PEP 683 changes PEP 683: Implement minor typographical changes Feb 19, 2022
CAM-Gerlach
CAM-Gerlach reviewed Feb 19, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few further textual fixes

pep-0683.rst Outdated Show resolved Hide resolved
pep-0683.rst Outdated Show resolved Hide resolved
@JelleZijlstra @CAM-Gerlach
Update pep-0683.rst
86c4959 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@JelleZijlstra
Copy link
Member Author

ping @ericsnowcurrently

JelleZijlstra and others added 2 commits February 25, 2022 09:46
@JelleZijlstra @CAM-Gerlach
Update pep-0683.rst
35f5c4f 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@JelleZijlstra
Update pep-0683.rst
8155237
ericsnowcurrently
ericsnowcurrently approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@JelleZijlstra JelleZijlstra merged commit 99bb6aa into main Feb 25, 2022
@JelleZijlstra JelleZijlstra deleted the JelleZijlstra-patch-1 branch February 25, 2022 18:12
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@eduardo-elizondo eduardo-elizondo eduardo-elizondo left review comments

@AA-Turner AA-Turner AA-Turner approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JelleZijlstra @ericsnowcurrently @eduardo-elizondo @AA-Turner @CAM-Gerlach @the-knights-who-say-ni