Add PEP titles and sections as reference title text #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
reviewed
Feb 26, 2022
There was a problem hiding this comment.
I spot tested this on a few different PEPs and PEP link types, and everything worked great—I particularly liked the inclusion of the section name; that was a very thoughtful and useful touch. I only had one small comment on the formatting of the titletext, and one nitpick on formatting the code.
pep_sphinx_extensions/pep_processor/transforms/pep_references.py
Outdated
Show resolved
Hide resolved
CAM-Gerlach
approved these changes
Feb 27, 2022
There was a problem hiding this comment.
LGTM, @AA-Turner , this is a terrific improvement. This should be good to merge at your convenience.
|
☝️ Just FYI, @warsaw , since IIRC you requested this. Also, @AA-Turner would it be straightforward to add similar titletext popups in a future PR for footnotes with the footnote content (like Wikipedia has), to avoid users having to click around to find it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the PEP number, title, and section target title to the title text of the link element.
A