Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 572: Typo, parenthesize -> parentheses #2370

Merged
merged 1 commit into from
Feb 28, 2022
Merged

PEP 572: Typo, parenthesize -> parentheses #2370

merged 1 commit into from
Feb 28, 2022

Conversation

eforgacs
Copy link
Contributor

Changing typo from "parenthesize" to "parentheses".

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@eforgacs

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Rosuav
Copy link
Contributor

Rosuav commented Feb 27, 2022

Huh, yup, that looks like a typo, or possibly an editing issue (could have been "require parenthesized expressions" or something). 👍

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This probably doesn't require the CLA.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no lawyer, but I can say fairly confidently that fixing a single-word typo would not be considered by any court to be a copyrightable expression.

@@ -898,7 +898,7 @@ The less confusing option is to make ``:=`` bind more tightly than comma.
Always requiring parentheses
----------------------------

It's been proposed to just always require parenthesize around an
It's been proposed to just always require parentheses around an
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions! Since this pull request just got merged, I'll make a separate pull request for these changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip these changes, since the existing text is suboptimal but not wrong. We should mostly avoid changes to finalized PEPs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current "It's" text is fine. It's just the parenthesis/parenthesize that is unambiguously wrong.

@eforgacs
Copy link
Contributor Author

Thanks! This probably doesn't require the CLA.

Thanks! In any event, I actually just signed the CLA, I guess it'll take some time for it to show up though. For the next pull request :)

@JelleZijlstra JelleZijlstra merged commit 07e5378 into python:main Feb 28, 2022
@eforgacs eforgacs deleted the patch-1 branch February 28, 2022 00:22
@@ -898,7 +898,7 @@ The less confusing option is to make ``:=`` bind more tightly than comma.
Always requiring parentheses
----------------------------

It's been proposed to just always require parenthesize around an
It's been proposed to just always require parentheses around an
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions! Since this pull request just got merged, I'll make a separate pull request for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants