Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: invert some images #2409

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 10, 2022

As detailed at https://discuss.python.org/t/styling-of-peps/13270/25?u=hugovk and https://discuss.python.org/t/styling-of-peps/13270/26?u=hugovk, a number of images need adapting to display in dark mode.

Use CSS to invert those images in PEP-0001 and marked 🔄 above.

@encukou
Copy link
Member

encukou commented Mar 10, 2022

Thank you for implementing this!
As a PEP author (and reader of the sources), I'd appreciate if the class was called e.g. invert-in-dark-mode.

(edited to add:) I work in light mode so the class won't do anything for me. With dark-mode in the name the reason for the class would be obvious.

@hugovk hugovk force-pushed the fix-dark-mode-images branch from 706f75b to 51b5d09 Compare March 10, 2022 14:56
@hugovk hugovk force-pushed the fix-dark-mode-images branch from 51b5d09 to 11bee7a Compare March 10, 2022 14:59
@hugovk
Copy link
Member Author

hugovk commented Mar 10, 2022

Thank you for implementing this! As a PEP author (and reader of the sources), I'd appreciate if the class was called e.g. invert-in-dark-mode.

(edited to add:) I work in light mode so the class won't do anything for me. With dark-mode in the name the reason for the class would be obvious.

Updated!

@CAM-Gerlach CAM-Gerlach added the infra Core infrastructure for building and rendering PEPs label Mar 11, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (at least per my previous investigation and spot checks of this one). Thanks, @hugovk

@AA-Turner AA-Turner force-pushed the fix-dark-mode-images branch from 9e8eff9 to 11bee7a Compare March 11, 2022 19:44
@AA-Turner
Copy link
Member

AA-Turner commented Mar 11, 2022

87a35b1fea as proposed uses pure reST :class: options rather than the .. rst-class extension -- purely an implementation change.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants