Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 685: address review feedback #2411

Merged
merged 5 commits into from
Mar 10, 2022
Merged

PEP 685: address review feedback #2411

merged 5 commits into from
Mar 10, 2022

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 10, 2022 •
edited
Loading

  • Specify the versions of pip and setuptools.
  • Loosen naming requirements to match PEP 508.
  • Use PEP 503 normalization.
  • Add some more references.
  • Have tools warn when reading invalid extra names.

@brettcannon
PEP 685: address review feedback
4f2c217 
- Specify the versions of pip and setuptools.
- Loosen naming requirements to match PEP 508.
- Use PEP 503 normalization.
- Add some more references.
@JelleZijlstra
Copy link
Member

Looks like you duplicated the text of the whole PEP.

@brettcannon
Copy link
Member Author

Looks like you duplicated the text of the whole PEP.

Ugh, bad merge.

@brettcannon brettcannon merged commit 7c1ff71 into python:main Mar 10, 2022
@brettcannon
Copy link
Member Author

@JelleZijlstra thanks for catching the duplicated text!

@brettcannon brettcannon deleted the pep-685-updates branch March 10, 2022 22:22
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettcannon @JelleZijlstra @the-knights-who-say-ni