Style: Fix vertical margins of def lists w/o <p>s to match those with #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just one: The |
|
Actually, looking at PEP 101 again, I'm finding it a bit difficult to specifically point to what exactly looked off to me. I'll file a PR if I'm able to place what it is -- instead of bothering people about the other nebulous whitespace concerns I may have. :) |
hugovk
approved these changes
Mar 15, 2022
|
Seems like this is good to go for now, so I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2300 , it was reported that the vertical margin varies substantially between entries with multiple paragraphs (i.e, another
<p>element) and those that only have one (i.e. just text, no<p>). Furthermore, the margins are still pretty tight as @pradyunsg reported, making them uncomfortable to read; they should be at least equivalent to the normal margin between paragraph-level elements.PEP 639 is a canonical example without and with this PR.
This resolves both of those concerns by just ensuring that
dl dd(except headers and footnotes, which are already overridden) have the same0.5rembottom vertical margin as paragraphs do:@pradyunsg Are there any additional vertical line spacing concerns you'd like me to address at this time?
Resolves #2300