-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 685: Copyedit and fix various minor issues following further changes #2428
Conversation
8ac2d18
to
ba7b80b
Compare
ba7b80b
to
09b5431
Compare
@CAM-Gerlach just to make sure there's no confusion, I'm letting you merge this since it's your PR. 🙂 |
c7e0f90
to
d3a0a26
Compare
@brettcannon I was letting you merge it because it was your PEP...heh. In all seriousness, sorry about that; I can be too conservative about merging things sometimes, especially on this repo. I reverted the other change you requested and will wait for the current issue with GitHub Actions/webhooks/pages/etc. to be resolved before merging, since when I merged a PR on another repo a short while ago, the GHP deploy never kicked off and the site didn't update, and I see that the builds on this PR pushing just now didn't trigger either. |
NP! If you didn't have commit rights I would have merged it, but since you do I prefer not to do the merge as you might have last-minute tweaks to do (see the miscommunication Jelle and I had I think last month). |
No, I totally understand—I was there for that, and I've seen that happen on other PRs here and elsewhere as its easy for there to be a miscommunication. If I'm doing knarly stuff like a rebase or critical changes I'll temporarily mark it as draft to prevent an inadvertent merge, but its a pretty heavy-handed tool to use for a lot of common cases, so that makes sense. Anyway, without further ado... |
Clarifications:
-
) is replaced or that only collapsing is done, and slightly expand examples.safe_extra()
and PEP 503 is normalizing non-PEP 508 characters, avoid implying that only collapsing (as opposed to both collapsing and replacement) is not done for-
and.
, and briefly mention the further inconsistency with the function's docstring.Copyedits:
Fixes: