-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 0: Make PEP titles in table clickable links #2429
PEP 0: Make PEP titles in table clickable links #2429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please could you also update the docstring on line 24?
662aac6
to
25447c2
Compare
Sure, done. |
Random side question @hugovk , but is there a reason the RTD deploy previews take so long (and provide relatively little feedback while they're building)? They take a full 3.5 minutes to generate and upload, which is over twice the time of the actual GH pages builds at 1.5 minutes (despite the latter using more rigorous, and thus slower, |
Looking at some logs:
The slowest bit is the Sphinx build, and isn't using Sphinx's
I see there's a The next slowest is installing dependencies (RTD docs):
One thing that sticks out there is the We can require dependencies in the config file but I think it installs those after the default ones. Worth a try though. The newest Python supported by 5.4.1 is 3.7, and we need 3.9, so probably makes more sense to ask RTD to upgrade instead, or allow skipping it if not needed. |
Thanks; I'm just used to having full control over the build environment, and it matching between my CIs, rather than it being managed for me. I assumed they'd install the project's deps from the same requirements file, but it seems like they are installing a whole heavy stack of others instead—and since they are managing it and pinning everything, and to old versions at that, I wonder why they aren't just cached in the environment? I was previously in favor of standardizing on RTD, and hopefully at least some of these issues can get speedily resolved, but if not maybe we should consider switching to something like Netlify for the previews (and retain the existing GHP setup for deploy), which would offer the same preview functionality but allow us to run the exact same code we do in our GitHub Actions, for full control, speed and consistency between builders. But we should presumably defer any such decision until Adam gets back and we discuss it with the team and community. |
As this is a straightforward tweak and its been 10 days, I'll go ahead and merge. |
As requested by @gvanrossum in #2364 ,
This PR does exactly that.