-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 11: define tiered platform support #2442
Conversation
Overall LGTM on the wording and concepts. |
+1 from me as well! |
I have prepared a PR to check and report support tier in configure script, python/cpython@main...tiran:support-tier |
Co-authored-by: Christian Heimes <christian@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding myself for Linux/GCC on aarch64 & powerpcle.
reverted within 24 hours. | ||
- Failures on these platforms block a release. | ||
- Promotion to this tier requires consensus/SC approval. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that buildbot URLs are reliable. In the past, some ids changed. Moreover, an URL is not easy to read.
Can you either replace the URL with the buildbot name, or add a label to the URL?
For example, replace https://buildbot.python.org/all/#/builders/125
with aarch64 Fedora Stable 3.x
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better yet (and per PEP 12),
`aarch64 Fedora Stable 3.x <https://buildbot.python.org/all/#/builders/125>`__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CAM-Gerlach that suggestion doesn't work since Victor's worry is about URL stability.
@vstinner what I can do is once this update goes in have a tier-2
label added to the appropriate buildbots and then simply link to that label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that; I thought by "add a label to the URL" he meant using a link with the buildbot name as descriptive link text, aarch64 Fedora Stable 3.x
, so it could still be located by name if its URL changes, but I'm guessing its referring to something else with the buildbots I'm unfamiliar with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He's referring to the labels you can apply to individual buildbots and then pull up a list of them, e.g. all of the 3.10 buildbots can be found with the 3.10
label at https://buildbot.python.org/all/#/builders?tags=%2B3.10 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks 👍
Co-authored-by: Ned Deily <nad@python.org> Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@tiran should we expand the vendor part of the triple to all the other tiers instead of just tier 1? That way it's at least consistent. |
What is the "triple" for that anyways? I made this one up based on some values. It's basically a 32-bit arm Debian derivative.
this is what is in config.log
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Yahoo! |
Thanks all for doing this, much appreciated! |
No description provided.