Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 11: define tiered platform support #2442

Merged
merged 21 commits into from
Apr 18, 2022

Conversation

brettcannon
Copy link
Member

No description provided.

pep-0011.txt Outdated Show resolved Hide resolved
@gpshead
Copy link
Member

gpshead commented Mar 18, 2022

Overall LGTM on the wording and concepts.

@encukou
Copy link
Member

encukou commented Mar 22, 2022

+1 from me as well!

pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
@tiran
Copy link
Member

tiran commented Mar 24, 2022

I have prepared a PR to check and report support tier in configure script, python/cpython@main...tiran:support-tier

brettcannon and others added 3 commits March 24, 2022 15:41
Co-authored-by: Christian Heimes <christian@python.org>
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding myself for Linux/GCC on aarch64 & powerpcle.

pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
reverted within 24 hours.
- Failures on these platforms block a release.
- Promotion to this tier requires consensus/SC approval.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that buildbot URLs are reliable. In the past, some ids changed. Moreover, an URL is not easy to read.

Can you either replace the URL with the buildbot name, or add a label to the URL?

For example, replace https://buildbot.python.org/all/#/builders/125 with aarch64 Fedora Stable 3.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better yet (and per PEP 12),

`aarch64 Fedora Stable 3.x <https://buildbot.python.org/all/#/builders/125>`__

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CAM-Gerlach that suggestion doesn't work since Victor's worry is about URL stability.

@vstinner what I can do is once this update goes in have a tier-2 label added to the appropriate buildbots and then simply link to that label.

Copy link
Member

@CAM-Gerlach CAM-Gerlach Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that; I thought by "add a label to the URL" he meant using a link with the buildbot name as descriptive link text, aarch64 Fedora Stable 3.x, so it could still be located by name if its URL changes, but I'm guessing its referring to something else with the buildbots I'm unfamiliar with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He's referring to the labels you can apply to individual buildbots and then pull up a list of them, e.g. all of the 3.10 buildbots can be found with the 3.10 label at https://buildbot.python.org/all/#/builders?tags=%2B3.10 .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks 👍

pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
pep-0011.txt Outdated Show resolved Hide resolved
brettcannon and others added 2 commits March 31, 2022 15:17
Co-authored-by: Ned Deily <nad@python.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
pep-0011.txt Outdated Show resolved Hide resolved
brettcannon and others added 2 commits April 1, 2022 14:33
Co-authored-by: Victor Stinner <vstinner@python.org>
@brettcannon
Copy link
Member Author

@tiran should we expand the vendor part of the triple to all the other tiers instead of just tier 1? That way it's at least consistent.

brettcannon and others added 5 commits April 8, 2022 17:11
What is the "triple" for that anyways? I made this one up based on some values. It's basically a 32-bit arm Debian derivative.
this is what is in config.log
@brettcannon brettcannon reopened this Apr 18, 2022
@brettcannon brettcannon marked this pull request as ready for review April 18, 2022 18:33
pep-0011.txt Outdated Show resolved Hide resolved
@brettcannon brettcannon requested a review from pablogsal April 18, 2022 18:55
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@brettcannon brettcannon merged commit 0806d52 into python:main Apr 18, 2022
@brettcannon brettcannon deleted the supported-platforms branch April 18, 2022 21:57
@vstinner
Copy link
Member

Yahoo!

@jezdez
Copy link

jezdez commented Apr 19, 2022

Thanks all for doing this, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.