PEP 686: Update based on discussion #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
methane
commented
Mar 20, 2022
| @@ -30,7 +30,7 @@ UTF-8 becomes de-facto standard text encoding. | |||
| default. | |||
| * Most websites and text data on the internet uses UTF-8. | |||
| * And many other popular programming languages including node.js, Go, Rust, | |||
| Ruby, and Java uses UTF-8 by default. | |||
| and Java uses UTF-8 by default. | |||
There was a problem hiding this comment.
I removed Ruby here because Ruby still uses locale encoding on Unix.
CAM-Gerlach
reviewed
Mar 20, 2022
ncoghlan
approved these changes
Mar 20, 2022
|
This update cleanly addresses the concern I raised on Discourse. |
|
Thank you for review. I merge this for now to continue more discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.