-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 630: Format and copyedit prior to conversion into a docs HOWTO guide #2459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
If you don't mind me asking, what's the main thing you'd change for a major rewrite?
ef73c09
to
637448e
Compare
Updating to retrigger the CLA bot
Sorry, I meant to reply to this but must have never submitted it, and its been so long I've forgotten what I was going to say other than restructuring it to be framed more as a guide, which would presumably be done when it is moved. |
@encukou can we merge this, or anything else you'd like to change at this point? |
Hey @encukou , any final thoughts on this one? |
Well, the restructuring you mentioned :) Thank you for the editing! |
Thank you for your kind words and encouraging me to! |
As originally requested by @encukou in #2450 .
Overall, the base prose quality of the document was very good, so there weren't that many changes necessary to begin with, without doing a major rewrite (when there are certainly bigger fish to fry in that department).
In general, I attempted to keep my changes fairly unobtrusive. There were only a few non-purely-copyediting additions that affect content/meaning, the only really significant was was adding a mention of PEP 683 (PEP-0683), which relates directly to the note on immutable objects not being truly immutable due to the refcount.