Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 630: Format and copyedit prior to conversion into a docs HOWTO guide #2459

Merged
merged 8 commits into from
Apr 19, 2022

Conversation

CAM-Gerlach
Copy link
Member

As originally requested by @encukou in #2450 .

Overall, the base prose quality of the document was very good, so there weren't that many changes necessary to begin with, without doing a major rewrite (when there are certainly bigger fish to fry in that department).

In general, I attempted to keep my changes fairly unobtrusive. There were only a few non-purely-copyediting additions that affect content/meaning, the only really significant was was adding a mention of PEP 683 (PEP-0683), which relates directly to the note on immutable objects not being truly immutable due to the refcount.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
If you don't mind me asking, what's the main thing you'd change for a major rewrite?

pep-0630.rst Outdated Show resolved Hide resolved
pep-0630.rst Outdated Show resolved Hide resolved
pep-0630.rst Outdated Show resolved Hide resolved
@CAM-Gerlach CAM-Gerlach requested a review from encukou March 25, 2022 19:46
@CAM-Gerlach
Copy link
Member Author

Updating to retrigger the CLA bot

If you don't mind me asking, what's the main thing you'd change for a major rewrite?

Sorry, I meant to reply to this but must have never submitted it, and its been so long I've forgotten what I was going to say other than restructuring it to be framed more as a guide, which would presumably be done when it is moved.

@CAM-Gerlach
Copy link
Member Author

@encukou can we merge this, or anything else you'd like to change at this point?

@CAM-Gerlach
Copy link
Member Author

Hey @encukou , any final thoughts on this one?

@encukou encukou merged commit dfdd865 into python:main Apr 19, 2022
@encukou
Copy link
Member

encukou commented Apr 19, 2022

anything else you'd like to change at this point?

Well, the restructuring you mentioned :)
But that can definitely be done later. With PEP 687 submitted to the SC, it's not a good time for restructuring.

Thank you for the editing!

@CAM-Gerlach
Copy link
Member Author

Thank you for your kind words and encouraging me to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants