Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 669: Update specification to return current callback object #2460

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

markshannon
Copy link
Member

No description provided.

@hugovk
Copy link
Member

hugovk commented Mar 23, 2022

The RTD build preview failed because this branch is a long way behind main so it doesn't have the RTD config version to switch the build from default Python 3.7 to required 3.9.

A rebase would fix it, but I wouldn't worry for such a small PR. Recommended for future PRs though :)

@markshannon
Copy link
Member Author

@JelleZijlstra Does the docs/readthedocs.org:pep-previews failure matter?

@JelleZijlstra
Copy link
Member

No, see Hugo's comment above.

@markshannon markshannon closed this Apr 1, 2022
@markshannon markshannon reopened this Apr 1, 2022
@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

We now have these buttons:

image

See #2495 for more.

I'll do an update with rebase.

@hugovk
Copy link
Member

hugovk commented Apr 1, 2022

Or rather I won't as I see you just found it :)

@markshannon
Copy link
Member Author

I don't like merging things with broken tests. Merging main is easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants