Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 686: Grammar fixes #2464

Merged
merged 3 commits into from
Mar 25, 2022
Merged

PEP 686: Grammar fixes #2464

merged 3 commits into from
Mar 25, 2022

Conversation

methane
Copy link
Member

@methane methane commented Mar 24, 2022

No description provided.

@CAM-Gerlach CAM-Gerlach changed the title PEP 686: Grammarly fixes. PEP 686: Grammarly fixes Mar 24, 2022
@hugovk
Copy link
Member

hugovk commented Mar 24, 2022

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Some of these undo Grammarly, some are new :)

pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
pep-0686.rst Outdated Show resolved Hide resolved
@hugovk hugovk changed the title PEP 686: Grammarly fixes PEP 686: Grammar fixes Mar 24, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Mar 24, 2022

Considering its tremendous marketing hype, while I was naturally very skeptical and didn't expect much, it still managed to be rather disappointing. It only catches a fraction of obvious, unambiguous grammar errors, never mind more complex issues; in some cases, the fix doesn't actually improve things, and in others, it changed perfectly valid (and even good-quality) sentences into ones with objective grammar errors. In all, the net result is only a marginal improvement

If you want to automatically fix the various grammar issues with this PEP, I'd suggest turning to CAMmerly instead, which uses a deep learning, neural network-trained copyediting engine tuned specifically on PEPs, all available for free to any PEP author on request—no need to pay for premium service.

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@Rosuav
Copy link
Contributor

Rosuav commented Mar 24, 2022

If you want to automatically fix the various grammar issues with this PEP, I'd suggest turning to CAMmerly instead, which uses a deep learning, neural network-trained copyediting engine tuned specifically on PEPs, all available for free to any PEP author on request—no need to pay for premium service.

Obligatory XKCD https://xkcd.com/2173/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants