Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Include trailing slash in RSS URLs to avoid 301 redirect #2474

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 27, 2022

https://peps.python.org/peps.rss includes links like:

      <guid isPermaLink="true">https://peps.python.org/pep-0686</guid>

Without the trailing /, there's an extra HTTP 301 redirect to add the slash, which adds a small but unnecessary delay which can vary between 20ms and 335ms.

See sphinx-doc/sphinx#10288 for some network waterfall diagrams with and without the extra request.

So let's include it:

      <guid isPermaLink="true">https://peps.python.org/pep-0686/</guid>

Also update pip and include wheel in virtualenv creation to remove a couple of warnings, noticeable during make rss.

@hugovk hugovk requested a review from CAM-Gerlach March 27, 2022 17:25
@hugovk hugovk requested a review from AA-Turner as a code owner March 27, 2022 17:25
@hugovk hugovk added the infra Core infrastructure for building and rendering PEPs label Mar 27, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hugovk

@hugovk hugovk merged commit a0351c0 into python:main Mar 28, 2022
@hugovk hugovk deleted the rss-trailing-slash branch March 28, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants