Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 671: Add Discussions-To header #2482

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

davidfstr
Copy link
Contributor

I've linked what appears to be the latest discussion thread for this PEP.

@CAM-Gerlach
Copy link
Member

Thanks! If you're going to update the Discussions-To, could you update the Post-History as well?

Post-History: 24-Oct-2021, `01-Dec-2021 <https://mail.python.org/archives/list/python-ideas@python.org/thread/UVOQEK7IRFSCBOH734T5GFJOEJXFCR6A/>`__

@davidfstr
Copy link
Contributor Author

could you update the Post-History as well?

Done. New revision posted.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @Rosuav ?

@davidfstr
Copy link
Contributor Author

@Rosuav, does this small revision to the headers of PEP 671 look okay to you?

@davidfstr davidfstr force-pushed the f/pep_671_discussions_to branch from 8332310 to f366d19 Compare April 15, 2022 13:49
@Rosuav
Copy link
Contributor

Rosuav commented Apr 15, 2022

Oops! I was sure that I'd pushed the button to say "yes, I approve of these changes", but something didn't happen. Not sure. Assume that I messed up somewhere in the UI, tha's the most likely cause. Yes, that looks fine, and I think this time that I've submitted an approving review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants