PEP 686: Update Discussions-To to match Post-History #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CAM-Gerlach I don't expect more large rewriting on this PEP. Would you do copyediting? |
|
Sure, I'll add it to my priority queue and try to get to it later today. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2489 updated the
Post-Historyto add the new thread (thanks for the quick update, @methane !). TheDiscussions-Towas not updated, though, which this PR does (as well as a formatting fix). In the future, I'd like to generateDiscussions-Toautomatically if it is not provided from the latestPost-Historyentry, so PEP authors only need to update it one place, but that's not implemented quite yet and there was some disagreement about the idea. (To note, the checks in #2484 actually caught this automatically)