PEP 687: amendments after feedback #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
commented
Apr 12, 2022
Comment on lines
+70
to
+72
| Static types that do not need module state access, and have no other reason to | ||
| be converted, should stay static. | ||
|
|
There was a problem hiding this comment.
@gvanrossum: Does this change, together with the sentence below, add enough emphasis for you?
There was a problem hiding this comment.
Another option would be to put the above sentence in a note. That would definitely highlight it.
|
@ncoghlan: FYI, I've applied your suggestions here. |
|
Let me piggy-back on this PR to add the python-dev thread to Post-History |
encukou
approved these changes
Apr 13, 2022
Sure, go ahead. |
CAM-Gerlach
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
LGTM @erlend-aasland and @encukou ; you'll need to update your branch (via a merge or rebase via the button, or locally) in order to trigger the CLA bot so this can be merged
JelleZijlstra
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.