-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra: remove two of the five instances of title at top of pages #2532
Conversation
The idea behind the contents title on the left was as it is sticky -- so the title is always visible. Perhaps that is a bad rationale, but that was why I added it! A |
Ah right, I see. Yes, I think it could still be removed. And I didn't mention the fifth place: the tab title :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed; I'd been just thinking the same. Being stickied is the one benefit, yes, but its still :stickied" in the tab title and not that important to have visible all the time that we need so many copies floating around, and it doesn't help on narrow widths/mobile.
As a corollary, I might suggest eliding the full title from the breadcrumbs and just leaving the PEP number, which is much shorter while still getting the same point across, and avoiding one or possibly two extra lines on narrow widths/mobile.
Unless we could just sticky the breadcrumbs bar, which would be reasonably handy for information and navigation purposes and justify keeping it there, but that's not entirely trivial.
Had thought the same :) I've pushed a commit to remove this too. |
As I've generally seen it recommended to include the current page in the breadcrumbs, and its particularly odd that it looks like its implied that the current page is the "PEP Index", what I'm suggesting is eliding the title but still including the PEP number, i.e. something like |
Got it, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again; thanks @hugovk !
this was removed in python/peps#2532
We currently have the PEP title shown four times at the top of each page:
https://peps.python.org/8
This PR removes the contents title on the left: