Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 681: Address Steering Council feedback #2555

Merged
merged 3 commits into from
Apr 25, 2022
Merged

PEP 681: Address Steering Council feedback #2555

merged 3 commits into from
Apr 25, 2022

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Apr 25, 2022

  • Changed wording of Rejected Ideas to avoid recommending changes in libraries or dictating how users respond to these limitations. @encukou
  • Added language in Rationale indicating that we will consider extending dataclass_transform in the future with features commonly used in libraries but not supported by dataclass. @AlexWaygood

@debonte debonte requested a review from JelleZijlstra as a code owner April 25, 2022 16:18
JelleZijlstra
JelleZijlstra reviewed Apr 25, 2022
View reviewed changes
pep-0681.rst Outdated Show resolved Hide resolved
@debonte @JelleZijlstra
Update pep-0681.rst
3afbfed 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
AlexWaygood
AlexWaygood reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this -- it's a big improvement, in my opinion!

pep-0681.rst Outdated Show resolved Hide resolved
pep-0681.rst Outdated Show resolved Hide resolved
pep-0681.rst Outdated Show resolved Hide resolved
AA-Turner
AA-Turner reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, please use or discard as you see fit.

A

pep-0681.rst Outdated Show resolved Hide resolved
pep-0681.rst Outdated Show resolved Hide resolved
pep-0681.rst Outdated Show resolved Hide resolved
@AA-Turner
Copy link
Member

Ahh, @AlexWaygood beat me to it -- mine and his seem similar suggestions.

A

@debonte @AA-Turner @AlexWaygood
Apply suggestions from code review
712809b 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AA-Turner
AA-Turner approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A

@AA-Turner AA-Turner changed the title Address Steering Council feedback PEP 681: Address Steering Council feedback Apr 25, 2022
@AA-Turner AA-Turner requested a review from encukou April 25, 2022 16:33
AlexWaygood
AlexWaygood approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :)

@brettcannon brettcannon merged commit d40ca16 into python:main Apr 25, 2022
@debonte debonte deleted the rejectedIdeasLanguage branch May 3, 2022 21:06
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@brettcannon brettcannon brettcannon approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@debonte @AA-Turner @brettcannon @JelleZijlstra @AlexWaygood