PEP 594: fix typos #2558
Merged
PEP 594: fix typos #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Apr 26, 2022
pep-0594.rst
Outdated
| @@ -476,7 +476,7 @@ mailcap | |||
|
|
|||
| The `mailcap <https://docs.python.org/3/library/mailcap.html>`__ package | |||
| reads *mail capability* files to assist in handling a file attachment in | |||
| an email. In most modern OSs the email client itself handles reacting to | |||
| an email. In most modern OSes the email client itself handles reacting to | |||
There was a problem hiding this comment.
Personally I would write "OSs" too, or better yet, rewrite to "operating systems" to avoid it.
Style guides are split.
OSes:
- https://developers.google.com/style/abbreviations?hl=en
- https://github.com/raspberrypilearning/style-guide/blob/master/style-guide.md
OSs
- https://docs.microsoft.com/en-us/style-guide/acronyms
- https://blog.apastyle.org/apastyle/2013/11/pluralize-numbers-and-abbreviations-without-apostrophes.html
- https://help.apple.com/applestyleguide/#/apsg3acde405
Always write in full, even when singular
There was a problem hiding this comment.
I personally have pretty much always seem OSes; syntactically I'm not aware of any instance where its explicitly allowed to put two "s"es together without something ("e", "''", etc.) separating them, which English has gone to great lengths to work around. But I agree it would probably be better to spell it out, or use an appropriate synonym.
JelleZijlstra
commented
Apr 26, 2022
AA-Turner
approved these changes
Apr 26, 2022
brettcannon
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.