PEP 690: Add flexibility to set_eager_imports() #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a callback to the proposed `importlib.set_eager_imports()`.
carljm
reviewed
May 3, 2022
|
Looks reasonable to me. In practice the flexibility we've used at Meta is just to use regex matching on the module name, so we could also add direct support for |
CAM-Gerlach
changed the title
Co-authored-by: Carl Meyer <carl@oddbird.net>
CAM-Gerlach
approved these changes
May 3, 2022
AA-Turner
reviewed
May 3, 2022
carljm
reviewed
May 3, 2022
Co-authored-by: Carl Meyer <carl@oddbird.net>
carljm
approved these changes
May 4, 2022
|
I can merge this unless you want Barry to take a look first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a callback to the proposed
importlib.set_eager_imports().