Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 8: Fix typos #2600

Merged
merged 1 commit into from
May 11, 2022
Merged

PEP 8: Fix typos #2600

merged 1 commit into from
May 11, 2022

Conversation

jbritton6
Copy link
Contributor

No description provided.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 11, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@CAM-Gerlach CAM-Gerlach changed the title PEP 8: Fixed typos. PEP 8: Fix typos May 11, 2022
@CAM-Gerlach CAM-Gerlach removed the request for review from ncoghlan May 11, 2022 17:15
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented May 11, 2022 •
edited
Loading

These are indeed indeed typos, and PEP 8 is an active process PEP, so it seems reasonable to accept this. While such a change is essentially certain to not be copywritable as an independent expression substantial enough to qualify for copyright protection under any jurisdiction, signing the CLA only takes a second and unlike most corporate CLAs, doesn't sign away any of your rights, it just asserts that you have the right to contribute the change (which you do, given it is not copyrightable in the first place).

warsaw
warsaw approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes. I will approve them and they should get merged once you sign the CLA.

CAM-Gerlach
CAM-Gerlach approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @jbritton6

@CAM-Gerlach CAM-Gerlach merged commit 46efeee into python:main May 11, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@warsaw warsaw warsaw approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbritton6 @CAM-Gerlach @warsaw