Infra: Use Docutils' list-table syntax for PEP 0

[AA-Turner]

Change in support of subindices.

A

[cpython-cla-bot]

The following commit authors need to sign the Contributor License Agreement:

• 9087854+aa-turner@users.noreply.github.com

Click the button to sign:

[AA-Turner]

Save for the CLA check, this is now done -- identical output in PEP 0, and a nice reduction in complexity as (almost) all of the custom PEP 0 transform is now gone (only the email address masking logic remains).

A

[AA-Turner]

*Not quite identical output to PEP 0, PEP titles are no longer truncated, and PEP 604's title now links correctly.

A

[hugovk]

It would be nice to have some tests for the changed emit_* functions in writer.py.

(Testing just emit_pep_category would also cover emit_column_headers and emit_pep_row.)

https://codecov.io/gh/python/peps/compare/278070ac9765efbd34e325d6080d8162bd529e99...b3a603d2fede03f207a26eaec584d13e6f8ebb13/src/pep_sphinx_extensions/pep_zero_generator/writer.py?before=pep_sphinx_extensions/pep_zero_generator/writer.py

[hugovk]

"Author(s)" is a bit ugly, for a table heading can we just put "Authors" or "Author"?

Also I think it's clear that the title is the PEP title, and the authors are the PEP authors, in a list of PEPs on the PEP index page on https://peps.python.org/ :)

Suggested change

	self.emit_text(" - PEP")
	self.emit_text(" - PEP Title")
	self.emit_text(" - PEP Author(s)")
	self.emit_text(" - PEP")
	self.emit_text(" - Title")
	self.emit_text(" - Authors")

[AA-Turner]

It would be nice to have some tests

I'm not sure what these would look like -- there's no real point to unit tests of just the function here, as what matters is that the entire list is a valid input to the list-table directive (a two-level list where the length of every second level list is uniform).

I'd then argue that the integration test part is handled by if it is parsed correctly as reST!

A

[AA-Turner]

(Also, the CLA is still not working -- just tried again)

[hugovk]

Yeah, tests not so valuable here. If nothing else, a test would show the code is at least running without exceptions, although we should probably notice it (but if not a super simple test would have helped ;)

CLA: I've pinged @ambv again.