Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 735: Add the acceptance post to Post-History #4053

Closed
wants to merge 1 commit into from
Closed

PEP 735: Add the acceptance post to Post-History #4053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion peps/pep-0735.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Status: Accepted
Type: Standards Track
Topic: Packaging
Created: 20-Nov-2023
Post-History: `14-Nov-2023 <https://discuss.python.org/t/29684>`__, `20-Nov-2023 <https://discuss.python.org/t/39233>`__
Post-History: `14-Nov-2023 <https://discuss.python.org/t/29684>`__, `20-Nov-2023 <https://discuss.python.org/t/39233>`__, `10-Oct-2024 <https://discuss.python.org/t/39233>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a typo? The last two links are identical.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't follow the whole discussion but this post might have some context: https://discuss.python.org/t/pep-735-dependency-groups-in-pyproject-toml/39233/328. I think the current procedure should be to add a link to the acceptance post in the Resolution field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Which is already there, so I don't know why we need this change at all)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we have two threads in the Post-History, and a direct link to the acceptance message in Resolution. This is correct.

The CI will also fail if you put a message in Post-History.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks like I somehow mixed up the links... My intent was to link to the acceptance post.

But I'll wait for #4054 and then I can just make this PR do that. 😄

Resolution: https://discuss.python.org/t/39233/312


Expand Down
Loading