Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Allow adding date to Resolution header #4061

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Meta: Allow adding date to Resolution header #4061

merged 6 commits into from
Oct 16, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Oct 16, 2024 •
edited by github-actions bot
Loading

Fixes #4054.

📚 Documentation preview 📚: https://pep-previews--4061.org.readthedocs.build/

hugovk
hugovk reviewed Oct 16, 2024
View reviewed changes
.pre-commit-config.yaml Show resolved Hide resolved
check-peps.py Outdated Show resolved Hide resolved
warsaw
warsaw approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but I also wonder whether it's obvious that the date link is pointing to the DPO thread in the examples. Maybe it's good enough, but I also kind of liked the "Discord thread" text! Just a thought, no objections from me.

hugovk
hugovk approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I added some extra tests in hugovk@6bc1e72 in case you want to pull it in. Or I can PR it your branch, or after this is merged?

@JelleZijlstra
Copy link
Member Author

Thanks Hugo! Feel free to push those tests onto my branch; if not I can run the right git commands in a little bit.

@hugovk
Copy link
Member

hugovk commented Oct 16, 2024

Pushed!

@JelleZijlstra JelleZijlstra mentioned this pull request Oct 16, 2024
Closed
@JelleZijlstra JelleZijlstra merged commit c56c5c5 into python:main Oct 16, 2024
23 checks passed
@JelleZijlstra JelleZijlstra deleted the resolutiondate branch October 16, 2024 16:05
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 16, 2024
Closed
4 tasks
@gaborbernat
Copy link
Contributor

Thanks folks, great improvement ❤️

gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@JelleZijlstra @hugovk @gvanrossum
Meta: Allow adding date to Resolution header (python#4061)
5ec90aa 
Fixes python#4054

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@warsaw warsaw warsaw approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach CAM-Gerlach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding a date to the Resolution of a PEP
4 participants
@JelleZijlstra @hugovk @gaborbernat @warsaw