-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asyncio gather vs TaskGroup in async_tree benchmarks #287
Comments
@willingc @gvanrossum what do you think? |
I think it's up to @mdboom. In general fixing benchmarks that already exist is painful enough that we don't do it unless there's no other way (e.g. a feature or dependency becomes obsolete). I am fine with adding another benchmark in the asyncio tree family. Maybe @kumaraditya303 has an opinion too? |
I vote for 1, we need benchmarks to cover both gather and taskgroups. Keep me in the loop for any PRs for this. |
currently, the async_tree set of benchmarks uses
asyncio.gather
, butasyncio.TaskGroup
is the newer cooler thing.recently I worked on a few asyncio optimizations, and had to patch pyperformance (itamaro@fe365c8) to measure the impact on
TaskGroup
(in addition to the proposed patch in gh-279 to cover eager task execution).as an aside, I was also able to compare gather vs TaskGroup (by comparing the results with and without that patch), and found that TaskGroup is faster than gather across the board!
I was wondering what would be the best way to address this in the benchmarks suite.
The text was updated successfully, but these errors were encountered: