Fix #359: Add a Sphinx benchmark #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
force-pushed
the
sphinx-benchmark
branch
from
a2c2095
to
6a87dc2
Compare
AA-Turner
reviewed
Oct 2, 2024
AA-Turner
reviewed
Oct 2, 2024
There was a problem hiding this comment.
This file can be deleted, it isn't used in the build.
|
Thanks for the feedback, @AA-Turner. I think I've addressed them all (and fixed the tests). |
- Remove config for builders we don't use (doctest, gettext, html, latex, epub, coverage, linkcheck) - Remove config for nitpicky mode (not enabled in the benchmark) - Remove irrelevant setup (e.g. doctest) - Remove setup for `notfound.extension` - Remove non-determinism with usage of `time.strftime()`
|
I've created a series of commits to potentially reduce the size of the benchmark -- and opened mdboom#1 for easy viewing of them. You may not want to include some (or any) of them, but the idea was to remove irrelevant things from the benchmark data (& also hopefully take preventative measures against so that the A |
Reduce the size of the sphinx benchmark
AA-Turner
reviewed
Oct 2, 2024
AA-Turner
reviewed
Oct 2, 2024
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly aimed at making sure our benchmarks catch whatever caused the GC regression in CPython. I measured about a 10% speedup on this when reverting the GC changes (and about 50% with debug builds, but performance of debug builds is not guaranteed anyway).