Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job_detail.html #2298

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Update job_detail.html #2298

merged 1 commit into from
Feb 14, 2024

Conversation

joncle
Copy link
Contributor

@joncle joncle commented Jul 26, 2023

Explicity escape the job description for the meta og:description where the description contains html which can throw off the rendering of the page...

See https://www.python.org/jobs/7314/ for example.

Explicity escape the job description for the meta og:description where the description contains html which can throw off the rendering of the page...

See https://www.python.org/jobs/7314/ for example.
@joncle
Copy link
Contributor Author

joncle commented Jul 26, 2023

This should close #2020 for now

@joncle
Copy link
Contributor Author

joncle commented Jul 26, 2023

Alternatively - it might be better to escape after truncating {{ object.description|truncatechars:200|escape }} at the risk of going over 200 characters but at least then it wouldn't run the risk of truncating escape sequences although I think that's less of a potential issue than having the meta tag bleed html into the page... happy with either.

@ewdurbin ewdurbin merged commit 8f37034 into python:main Feb 14, 2024
1 check passed
@JacobCoffee
Copy link
Member

This seems it did not do the thing needed to fix as examples in #2307 and #2020 remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants