infra: format with ruff #2540
Open
infra: format with ruff #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's about 7000 issues found with ruff lint. taking away docstring and missing type annotations its not so bad at around ~500 so working through some of those to see if its something we want to do (i do 🥹) |
|
Zero opposition, but please can handle all concerns then rebase this down to one commit so we can do something like https://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html#avoiding-ruining-git-blame |
hugovk
reviewed
Sep 13, 2024
| "We're happy to announce the new way to file a contributor " | ||
| "agreement: on the web at", | ||
| self.entries[0]['summary'] | ||
| "We're happy to announce the new way to file a contributor " "agreement: on the web at", |
There was a problem hiding this comment.
Turn on ISC to catch these:
Suggested change
| "We're happy to announce the new way to file a contributor " "agreement: on the web at", | |
| "We're happy to announce the new way to file a contributor agreement: on the web at", |
https://docs.astral.sh/ruff/rules/#flake8-implicit-str-concat-isc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Close