Fixup some pyright CI configuration details (#12690)

python · Sep 23, 2024 · 9f033bf · 9f033bf
1 parent bfaa3d2
commit 9f033bf
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/.github/workflows/meta_tests.yml b/.github/workflows/meta_tests.yml
@@ -61,7 +61,6 @@ jobs:
           version: PATH
           python-platform: ${{ matrix.python-platform }}
           python-version: "3.9" # Oldest version supported for running scripts and tests
-          extra-args: --threads
           project: ./pyrightconfig.scripts_and_tests.json
   stubsabot-dry-run:
     name: Stubsabot dry run

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -145,15 +145,13 @@ jobs:
           version: PATH
           python-platform: ${{ matrix.python-platform }}
           python-version: ${{ matrix.python-version }}
-          extra-args: --threads
           annotate: ${{ matrix.python-version == '3.12' && matrix.python-platform == 'Linux' }} # Having each job create the same comment is too noisy.
       - name: Run pyright with stricter settings on some of the stubs
         uses: jakebailey/pyright-action@v2
         with:
           version: PATH
           python-platform: ${{ matrix.python-platform }}
           python-version: ${{ matrix.python-version }}
-          extra-args: --threads
           annotate: ${{ matrix.python-version == '3.12' && matrix.python-platform == 'Linux' }} # Having each job create the same comment is too noisy.
           project: ./pyrightconfig.stricter.json
       - name: Run pyright on the test cases
@@ -162,7 +160,6 @@ jobs:
           version: PATH
           python-platform: ${{ matrix.python-platform }}
           python-version: ${{ matrix.python-version }}
-          extra-args: --threads
           annotate: ${{ matrix.python-version == '3.12' && matrix.python-platform == 'Linux' }} # Having each job create the same comment is too noisy.
           project: ./pyrightconfig.testcases.json
 

diff --git a/pyrightconfig.stricter.json b/pyrightconfig.stricter.json
@@ -100,7 +100,6 @@
         "stubs/vobject",
         "stubs/workalendar",
         "stubs/wurlitzer",
-        "stubs/xdgenvpy"
     ],
     "typeCheckingMode": "strict",
     // TODO: Complete incomplete stubs

diff --git a/tests/pyright_test.py b/tests/pyright_test.py
@@ -37,7 +37,7 @@ def main() -> None:
     # version installed into the virtual environment, due to failures on some
     # platforms. https://github.com/python/typeshed/issues/11614
     os.environ["PYRIGHT_PYTHON_FORCE_VERSION"] = pyright_version
-    command = [npx, f"pyright@{pyright_version}"] + sys.argv[1:] + ["--threads"]
+    command = [npx, f"pyright@{pyright_version}"] + sys.argv[1:]
     print_command(command)
 
     ret = subprocess.run(command).returncode