openpyxl: Add _WorkbookChild / ReadOnlyWorksheet / Workbook annotations
#11677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9511 and added all
_WorkbookChild/ReadOnlyWorksheet/Workbookannotations I could find using the following search:I updated parameter annotations for all of the following mathcing "whole word" regex:
worksheet[,:\)].*_worksheet[,:\)]sheets?[,:\)]ws[,:\)]parent[,:\)]wb[,:\)]workbook[,:\)].*_workbook[,:\)]And the return type of functions matching the following:
def .*?workbook.*?\(def .*?sheet.*?\((note I looked for a few other variations of the above words, but they didn't match anything)
Now that typeshed has support for PEP 696,
Workbookshould probably be made generic on read_only and write_only, but that's out of scope for this PR. (see #9940 )Added refs to python/mypy#6700