Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stubs for m3u8 #12683

Merged
merged 7 commits into from
Oct 1, 2024
Merged

add stubs for m3u8 #12683

merged 7 commits into from
Oct 1, 2024

Conversation

DinhHuy2010
Copy link
Contributor

No description provided.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not a full review, just a few things I noticed.

stubs/m3u8/@tests/stubtest_allowlist.txt Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/__init__.pyi Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/httpclient.pyi Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/httpclient.pyi Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/httpclient.pyi Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/httpclient.pyi Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DinhHuy2010 DinhHuy2010 mentioned this pull request Sep 29, 2024
Open
srittau
srittau requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few notes below. Also, please either add a short comment explaining the allowed types for each Any or change the Anys to Incomplete for now.

stubs/m3u8/m3u8/mixins.pyi Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/mixins.pyi Outdated Show resolved Hide resolved
stubs/m3u8/m3u8/model.pyi Outdated Show resolved Hide resolved
@DinhHuy2010
Copy link
Contributor Author

got this error on changing
image

@srittau
Copy link
Collaborator

srittau commented Oct 1, 2024

You should remove the # type: ignore from the first line and see what happens. We don't really use module-level ignores in typeshed anyway.

@DinhHuy2010
Copy link
Contributor Author

no error from mypy

@DinhHuy2010
fix stubs again
1e23e03 
 - replace Any with Incomplete (on args is removed aka unannoted)
 - _PlaylistProtocol is no longer inherited from BasePathMixin
 - BasePathMixin is no longer a protocol (matching runtime behavior)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 1c96234 into python:main Oct 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DinhHuy2010 @srittau @JelleZijlstra