Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message.pyi: Now takes Address as EmailMessage header #2924

Merged
merged 3 commits into from
Oct 10, 2019
Merged

message.pyi: Now takes Address as EmailMessage header #2924

merged 3 commits into from
Oct 10, 2019

Conversation

utkarsh2102
Copy link
Contributor

Fixes #2863

@utkarsh2102 utkarsh2102 mentioned this pull request Apr 17, 2019
Closed
@utkarsh2102 utkarsh2102 force-pushed the email_header branch 2 times, most recently from 3d4de6e to f6a6485 Compare April 17, 2019 20:46
srittau
srittau reviewed Apr 30, 2019
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to distinguish between header types for arguments (an Union) and for return types (Any).

@srittau srittau merged commit 1a932ce into python:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email example from python docs doesn't validate: Address as EmailMessage header
3 participants
@utkarsh2102 @srittau @JelleZijlstra