Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update importlib.metadata typings for 3.10 #7331

Merged

Conversation

itaisteinherz
Copy link
Contributor

Fixes #7262
Refs #6557

// cc @Molkree @hauntsaninja

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@itaisteinherz
Copy link
Contributor Author

itaisteinherz commented Feb 20, 2022

At first I thought that I'll need to add EntryPoints as well, but after another look it seems like it isn't used by any public method.

@itaisteinherz
Copy link
Contributor Author

At first I thought that I'll need to add EntryPoints as well, but after another look it seems like it isn't used by any public method.

It seems like EntryPoints will be required for the typing of SelectableGroups.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

stdlib/importlib/metadata/__init__.pyi Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing I noticed, looks good to me otherwise.

stdlib/importlib/metadata/__init__.pyi Show resolved Hide resolved
@itaisteinherz itaisteinherz changed the title Update importlib_metadata typings for 3.10 Update importlib.metadata typings for 3.10 Feb 24, 2022
@JelleZijlstra JelleZijlstra merged commit f4b43da into python:master Feb 25, 2022
@itaisteinherz itaisteinherz deleted the feature/importlib-metadata-updates branch February 25, 2022 08:27
@itaisteinherz
Copy link
Contributor Author

itaisteinherz commented Feb 25, 2022

@AlexWaygood should I have also added SelectableGroups and EntryPoints to __all__? I just noticed your PR #7326, which initially added __all__, and noticed I forgot to add them.
(I also noticed that you didn't include EntryPoint in __all__?)

@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 25, 2022

@AlexWaygood should I have also added SelectableGroups and EntryPoints to __all__? I just noticed your PR #7326, which initially added __all__, and noticed I forgot to add them. (I also noticed that you didn't include EntryPoint in __all__?)

@itaisteinherz, none of them are included in __all__ at runtime, so I don't see any reason to include them in __all__ in the stub :) https://github.com/python/cpython/blob/2c228a7b8f89e9ed8d390370abd771d4993b79d8/Lib/importlib/metadata/__init__.py#L30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stub for importlib.metadata on Python 3.10 is incomplete
7 participants