Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing.TypeVarTuple, Unpack, assert_type #7501

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

JelleZijlstra
Copy link
Member

Unpack: _SpecialForm

class TypeVarTuple:
__name__: str
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anticipating python/cpython#31954.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait until that's merged before merging this, or do you reckon we're good to go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to wait I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Converting this to a draft for now so it doesn't get accidentally merged in the meantime)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the CPython change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I merged this one :)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood marked this pull request as draft March 17, 2022 05:51
@JelleZijlstra JelleZijlstra marked this pull request as ready for review March 18, 2022 17:57
@AlexWaygood AlexWaygood merged commit 4d23919 into master Mar 18, 2022
@AlexWaygood AlexWaygood deleted the JelleZijlstra-patch-1 branch March 18, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants