Add __setattr__ to logging.LogRecord
#8064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/util/logging.py:80: error: Unused "type: ignore" comment
+ sphinx/util/logging.py:434: error: Unused "type: ignore" comment
|
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Aug 12, 2022
Presumably python/typeshed#8064 makes this ok
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Aug 12, 2022
Presumably python/typeshed#8064 makes this ok
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Aug 12, 2022
Presumably python/typeshed#8064 makes this ok
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Sep 28, 2022
Presumably python/typeshed#8064 makes this ok Cherry-picked from #13521
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Sep 30, 2022
Presumably python/typeshed#8064 makes this ok Cherry-picked from #13521
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Sep 30, 2022
* Update mypy and mypy-zope * Unignore assigning to LogRecord attributes Presumably python/typeshed#8064 makes this ok Cherry-picked from #13521 * Remove unused ignores due to mypy ParamSpec fixes python/mypy#12668 Cherry-picked from #13521 * Remove additional unused ignores * Fix new mypy complaints related to `assertGreater` Presumably due to python/typeshed#8077 * Changelog * Reword changelog Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7833