-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.10.0.1 breaks CI in importlib_metadata #865
Comments
Thanks for bringing this up! I can release a new version as soon as this is fixed, but we should probably get CI back up first (#864). |
python/typing#865 - CI fails under Python 3.10
python/typing#865 - CI fails under Python 3.10
That specific version has a bug on Python 3.10 See python/typing#865
That specific version has a bug on Python 3.10 See python/typing#865
Remove once python/typing#865 has been fixed
Change-Id: I7b35bc86a7b78f96d8006515341f7cc7a6b49dcc References: python/typing#865
@jaraco thanks for highlighting this to us and sorry about that. I'll try to fix this ASAP. |
Fixed in #869 |
Yep. Thanks again @sobolevn! |
The CI PR might take a while longer so I'm going to try running tests locally myself and then release 3.10.0.2 with the fix. |
@JelleZijlstra Feel free to merge the CI PR. I think it's "good enough" and can be cleaned up later |
We need to wait for the CLA to land. |
Ah, ok. |
I'm awfully confused why plain
|
Note that there were some last-minutes changes in |
Judging by my runs, it's similarly broken everywhere from 3.10.0-b2 to 3.10.0-rc1. |
Nevermind, it seems that I'd made a mistake -- I just tested this on 3.10a7 and it didn't pass there either (I think I might've tested just 3.5-3.9). I'm really sorry everyone. Hopefully our new CI with 3.10 runs will catch such things in the future. I'll make sure to run 3.10 tests locally too. |
Update: I just released 3.10.0.2, which passes tests under 3.10.0rc1. |
That specific version has a bug on Python 3.10 See python/typing#865
Remove once python/typing#865 has been fixed
…o version 4.8.2 Alan Fregtman (1): .editorconfig: Set max_line_length to 88 for Python files. Jason R. Coombs (16): Pin against broken typing-extensions as reported in python/typing#865. Fixes python/importlib_metadata#350. Extract list method passthrough into a factory function. Refactor Distribution.files to use pass_none to handle a None value from _read_files*. Revert "Pin against broken typing-extensions as reported in python/typing#865. Fixes python/importlib_metadata#350." Add intersphinx mappings for Python to prevent spurious nitpicky failures. Fixes jaraco/skeleton#51. Remove docstring as comment. It's over-specific (pytest-mypy) but also any user of mypy is probably familiar that mypy doesn't handle conditional imports elegantly. Test on Python 3.10 (final). Rely on pytest 6 and drop workaround for pytest-dev/pytest#6178. Remove references to specific Python versions, as this project and CPython are evolving over time. Remove more references to specific Python versions. Remove wheel from build requirements. It's implied for wheel builds. Ref pypa/setuptools#1498. Fall back to legacy resolver in pip. Workaround for pypa/pip#9143. Restore new resolver for pip. Proper fix for pypa/pip#9143. Add test for FastPath on empty path. Ref #353. Restore fallback when FastPath.root is empty. Fixes #353. Update changelog. Ref #353.
In python/importlib_metadata#350, I observed that the tests on Python 3.10 started failing. Looking at a diff of the dependencies, I can see that the issue is brought about by the introduction of the recently released typing-extensions==3.10.0.1.
Error message is:
I suspect this issue will have widespread impact on environments running under Python 3.10.
The text was updated successfully, but these errors were encountered: