Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LiteralString #1053

Merged
merged 11 commits into from
Feb 11, 2022
Merged

add LiteralString #1053

merged 11 commits into from
Feb 11, 2022

Conversation

JelleZijlstra
Copy link
Member

Based on the latest revision of PEP 675 (cc @pradeep90).

The implementation is copied from Self, so the only interesting part is the docstring.

pradeep90
pradeep90 approved these changes Feb 2, 2022
View reviewed changes
Copy link

@pradeep90 pradeep90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we wait in case someone has last-minute, heavy objections to the LiteralString name?

typing_extensions/src/test_typing_extensions.py Show resolved Hide resolved
typing_extensions/src/test_typing_extensions.py Outdated Show resolved Hide resolved
@JelleZijlstra
Copy link
Member Author

Good idea, I'll hold off on merging for a while. I'm hoping to release typing-extensions 4.1 once we have PEP 646 support, dataclass_transform, all the functions I'm adding to typing, and this one all implemented.

@srittau srittau marked this pull request as draft February 2, 2022 10:20
@srittau
Copy link
Collaborator

srittau commented Feb 2, 2022

I've converted this to a draft, just so I don't merge this by accident. Please unconvert (or merge) when ready.

@JelleZijlstra JelleZijlstra mentioned this pull request May 19, 2022
Closed
4 tasks
sobolevn
sobolevn reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

typing_extensions/src/typing_extensions.py Outdated Show resolved Hide resolved
typing_extensions/src/test_typing_extensions.py Show resolved Hide resolved
typing_extensions/src/test_typing_extensions.py Show resolved Hide resolved
typing_extensions/src/test_typing_extensions.py Show resolved Hide resolved
typing_extensions/src/test_typing_extensions.py Show resolved Hide resolved
@JelleZijlstra JelleZijlstra marked this pull request as ready for review February 11, 2022 02:15
@JelleZijlstra JelleZijlstra merged commit f6e8272 into python:master Feb 11, 2022
@JelleZijlstra JelleZijlstra deleted the pep675 branch February 11, 2022 02:21
@pradeep90 pradeep90 mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@pradeep90 pradeep90 pradeep90 approved these changes

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JelleZijlstra @srittau @pradeep90 @sobolevn @the-knights-who-say-ni