-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isinstance check for Generic classes #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I think this probably also needs a changelog entry (under a new "Unreleased" heading at the top of the file)
(A test would also be great, to ensure that this doesn't regress again) |
Added test and changelog item |
Looks like your latest commit might have been authored using a different email address, which is upsetting the CLA bot. Would you mind signing it again with your second email address? |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I confirmed that the new test fails on main
, and passes with this PR. Sorry again for the breakage!
This fix was released as part of version 4.6.2 just now. |
After upgrading to
typing-extensions==4.6.1
this code example started failing on Python 3.7:Who said that objects of generic class must have
_is_protocol
property?Caused by #184