-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement TypedDict in a similar way to Python #191
Conversation
Seems like |
Conceptually, it's better for |
TypedDict now closely follows the implementation and tests in Python main, except for some interesting workarounds to get generics to work, and a few other details that don't work in old versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Haven't reviewed the tests in depth, but I trust you're testing everything that's tested in CPython?
Looks like a few tests are failing on py312 btw
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
All green now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
No description provided.