Add action to automatically check for updates and create a PR #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Sep 25, 2024
Comment on lines
93
to
111
| - name: Create PR | ||
| id: commit_changes | ||
| if: env.CHANGES_DETECTED == 'true' | ||
| run: | | ||
| git checkout -b "updates/update_${TZDATA_VERSION}" | ||
| git commit -m "Update tzdata to version $TZDATA_VERSION" \ | ||
| -m "$TZDATA_NEWS" | ||
| git push --force origin "updates/update_${TZDATA_VERSION}" | ||
|
|
||
| - name: Create pull request | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| if: env.CHANGES_DETECTED == 'true' | ||
| run: | | ||
| gh pr create --title "Update tzdata to version $TZDATA_VERSION" \ | ||
| --body "$TZDATA_NEWS" \ | ||
| --base master \ | ||
| --head $(git rev-parse --abbrev-ref HEAD) \ | ||
| --label "automatic-updates" |
There was a problem hiding this comment.
We have both "Create PR" and "Create pull request" steps here. Should there be only one?
The second one failed here: https://github.com/python/tzdata/actions/runs/11019333824/job/30601666394?pr=82
There was a problem hiding this comment.
Ah, that's I think a naming problem. The first one commits the changes, the second one creates the pull request.
The second one failed yesterday because it was being triggered from a PR. It worked successfully when I manually triggered it on my own fork, so I think this will work next time there's a tzdata update: https://github.com/pganssle/tzdata/actions/runs/11020129915/job/30604223890
pganssle
force-pushed
the
automatic_pr
branch
from
7a68346
to
88bfc68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thing to do is to make sure that the
tox -e updatescript doesn't do anything if you are already on the latest version. If it finds anything, we're ready for an update. This will create a release candidate.Fixes #8