Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text int typing for positions to float #2221

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

DigiDuncan
Copy link
Collaborator

Pyglet types these attributes as int but happily accepts float, and we use float for position everywhere else and ¯\(ツ)

It was messing up my typing in Charm frankly so I figured other people would run into it

@DigiDuncan DigiDuncan changed the title Text int typingfor positions to float Text int typing for positions to float Jul 8, 2024
@einarf
Copy link
Member

einarf commented Jul 8, 2024

@eruvanos was the one changing the typing on these in the past. Should be discussed with him.

Moving deeper I would also check with the pyglet people why these were typed as int. It's something we can change in pyglet for 2.1 if it makes sense.

Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: 👍 Do it

This was partly covered in #2183 but that will take forever to merge, so I'll just rebase.

Moving deeper I would also check with the pyglet people why these were typed as int.

I've been discussing this with them on Discord:

@pushfoo pushfoo merged commit 4cc2a87 into pythonarcade:development Jul 8, 2024
7 checks passed
@einarf
Copy link
Member

einarf commented Jul 8, 2024

Thanks for this fix. The squiggly lines in my editor have been bothering me 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants