Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyglet2.1dev$VERSION updates #2226

Merged
merged 45 commits into from
Jul 18, 2024
Merged

Pyglet2.1dev$VERSION updates #2226

merged 45 commits into from
Jul 18, 2024

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Jul 9, 2024 •
edited
Loading

Supercedes #2183 (same contents, just a branch on the main Arcade repo)

Big changes:

  1. Modified code to use pyglet.options object appropriately
  2. No more __eq__ deletion tricks
  3. Partly document and type the pyglet text stack's apparent secret undocumented support for partial bolding (yes, I tested this)

Other changes:

  • Sound annotations
  • Align & pyright's spec-violating ideas o on Literal for text
  • Document the apparent undocumented support for string bold values across non-win32 platforms
  • Use | None in a few places
  • Temp fix float vs int for window sizes (Apple supports these, apparently to simplify touch events)

To resolve:

  • Verify that the workaround for pyglet font loading changes work
  • Figure out the current actual state of Label's font return values
  • Resolve italic and bold + strings vs bools
    • pyglet seems open to splitting bold into weight and bold
      2.1 seems Upstream fixes (Digi might be look into this, tbd)
    • Look for ways to simplify and/or make our Text more durable
  • The GUI stack & event handlers
  • Whatever's going with Screen types and pyglet's import trickery

@pushfoo pushfoo mentioned this pull request Jul 9, 2024
Closed
10 tasks
@pushfoo pushfoo mentioned this pull request Jul 11, 2024
Closed
@pushfoo
Bump to pyglet == 2.1dev3
6c8d839
@pushfoo
Remove del trick for getting future vec behavior
d92fee1
@pushfoo
Update to options object
9d1a916
@pushfoo
Switch arcade/__init__.py to use OOP options object
d5aa0a3
@pushfoo
Convert applications.py to OOP pyglet options
f634926
@pushfoo
Convert doc on headless to use options object
446ee04
@pushfoo
Fix a comment in arcade/__init__.py
c840695
@pushfoo
Update tests/__init__.py
8a2fce0
@pushfoo
Fix formatting
5148b7a
@pushfoo
Type compatibility fix in controller db loading
30efe07
@pushfoo
Use pyglet.media.Source instead of a Union type
760f1ba
@pushfoo
Fix color typing in arcade.Text
9046d3d
@pushfoo
Ignore over-strict pyright Literal opinion
7af7363
@pushfoo
Attempt to patch up the font loader
35f219f
@pushfoo
Use new-style | None in application.Window.__init__
8ab0975
@pushfoo
Update some typing for set_fullscreen
482e7ca 
* Use new-style | None

* Add casting and TODO on resolving screen coord issues upstream

* Mention rounding issue in set_fullscreen
@pushfoo
Add temporary type ignore for font_size
497dadb
@pushfoo
Update type + doc for arcade.text bold support
5bb81c6 
* Update top-level docstring

* Update bold setter & getter

* Update bold return types
@pushfoo
Temporarily use pyglet development branch directly
323645d 
* Use development pyglet in rolling release mode + comment it

* Add commented-out future pyglet == 2.1dev4 release we can swap to it later
@pushfoo
Formatting
25bdf04
@pushfoo
Use newly released pyglet==2.1dev4
f7f16d7
@pushfoo
Projection funcs: remove inner tuple for Mat4 init
f312be0
@pushfoo
add dot to pyproject.toml (no idea why pip resolves that)
70a70ca
@pushfoo
Use Vec3 for now in perspective example
06cae35
@pushfoo
Centralize headless + add some type: ignore
97eb731 
* Centralize headless

* Add some type: ignore since pyglet did vague .pyi
@pushfoo
type: ignore in sound.py
7a5d833
@einarf einarf mentioned this pull request Jul 18, 2024
Open
7 tasks
@einarf einarf merged commit 6e8259d into development Jul 18, 2024
8 checks passed
@einarf einarf deleted the pyglet2.1dev-updates branch July 18, 2024 11:57
@pushfoo pushfoo mentioned this pull request Jul 20, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pushfoo @einarf