Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#3269: unwrap tensor shape without opt val #3279

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Fixes #3269
extract_var_range_info is used by unwrap_tensor_shape and construct_dynamic_input
for the unwrap_tensor_shape, it only needs min and max
for the construct_dynamic_input, it needs min, opt and max
So added a flag to mark whether opt val is optional or not.
If it is optional then if cannot get the opt val(if got exception), we can still continue
if it is not optional then it will raise Error(if got exception)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Nov 4, 2024
@github-actions github-actions bot requested a review from peri044 November 4, 2024 23:27
py/torch_tensorrt/dynamo/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit aa36e9a into main Nov 5, 2024
55 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] "Cannot convert symbols to int" when compiling graph that outputs tensor with dynamic shape
3 participants