Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc rendering #972

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix doc rendering #972

merged 1 commit into from
Oct 20, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Oct 20, 2020

Currently there is no version specification for sphinx in docs and pip install -r requirements.txt would install the version that produces the corrupted rendering for function signatures. This issue is fixed by using 2.4.4, which is the same version as PyTorch

Note: This commit should also go to master branch.

Before

Screen Shot 2020-10-20 at 16 13 47

After

Screen Shot 2020-10-20 at 16 00 45

@astaff
Copy link
Contributor

astaff commented Oct 20, 2020

LGTM :-)

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for catching this.

@vincentqb
Copy link
Contributor

As you pointed out offline, this might need to go in master too, though we'll need to keep track of the pinned version later.

@mthrok mthrok merged commit ac17b64 into pytorch:release/0.7 Oct 20, 2020
@mthrok mthrok deleted the fix-doc-build branch October 20, 2020 20:47
mthrok added a commit to mthrok/audio that referenced this pull request Oct 20, 2020
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
clarifying what pytorch/examples is and how to contribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants