New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directly using dim order for memory format comparsion. #2170

Closed

Gasoonjia wants to merge 3 commits into pytorch:main from Gasoonjia:export-D54341919

Contributor

Gasoonjia commented Feb 29, 2024

Differential Revision: D54341919

pytorch-bot bot commented Feb 29, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2170

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 1 Unrelated Failure

As of commit 5c1c572 with merge base 8532e79 ():

NEW FAILURES - The following jobs have failed:

Lint / lintrunner / linux-job (gh)
>>> Lint for runtime/core/exec_aten/testing_util/tensor_factory.h:
pull / test-llama-runner-linux (fp16, buck2) / linux-job (gh)
RuntimeError: Failed to compile /tmp/tmpke3rf5yt/data.json to /tmp/tmpke3rf5yt/data.pte. Set ET_EXIR_SAVE_FLATC_INPUTS_ON_FAILURE=1 to save input files on failure.
pull / test-llama-runner-linux (fp16, cmake) / linux-job (gh)
RuntimeError: Failed to compile /tmp/tmpidlyzdyg/data.json to /tmp/tmpidlyzdyg/data.pte. Set ET_EXIR_SAVE_FLATC_INPUTS_ON_FAILURE=1 to save input files on failure.
pull / test-llama-runner-linux (fp32, buck2) / linux-job (gh)
RuntimeError: Failed to compile /tmp/tmpbg9644xw/data.json to /tmp/tmpbg9644xw/data.pte. Set ET_EXIR_SAVE_FLATC_INPUTS_ON_FAILURE=1 to save input files on failure.
pull / test-llama-runner-linux (fp32, cmake) / linux-job (gh)
RuntimeError: Failed to compile /tmp/tmpyi3h_xcy/data.json to /tmp/tmpyi3h_xcy/data.pte. Set ET_EXIR_SAVE_FLATC_INPUTS_ON_FAILURE=1 to save input files on failure.
pull / unittest / linux (buck2) / linux-job (gh)
RuntimeError: Command docker exec -t 10eee8d410c6a3a2293797c114e69550181b15a88f64ee381b4f0a0f862f09ab /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / macos (buck2) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Feb 29, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

facebook-github-bot added CLA Signed fb-exported labels

Gasoonjia force-pushed the export-D54341919 branch from 4364e6b to 1bd6c9a Compare

March 5, 2024 06:22

Contributor

facebook-github-bot commented Mar 5, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

118f791

Summary:

bypass-github-export-checks

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

380313f

Summary:

bypass-github-export-checks

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

d8145e3

Summary:

bypass-github-export-checks

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

25b0347

Summary:

bypass-github-export-checks

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from 1bd6c9a to 25b0347 Compare

March 5, 2024 21:19

Contributor

facebook-github-bot commented Mar 5, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

a8cfd76

Summary:

bypass-github-export-checks

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

f6fe408

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

f97479a

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from 25b0347 to f97479a Compare

March 7, 2024 23:58

Contributor

facebook-github-bot commented Mar 7, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

b411a7c

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from f97479a to b411a7c Compare

March 11, 2024 06:30

Contributor

facebook-github-bot commented Mar 11, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

8487a23

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

77ceedf

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

b088c0b

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

447f8ff

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

cb52c75

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

28017a8

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

8ada546

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

8d91187

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from b411a7c to 67da904 Compare

March 20, 2024 17:17

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

67da904

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from 67da904 to 3341cde Compare

March 20, 2024 23:10

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

3341cde

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Contributor

facebook-github-bot commented Mar 20, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

406db46

Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from 3341cde to a7eb3a2 Compare

March 20, 2024 23:47

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

a7eb3a2

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai

Differential Revision: D54341919

Contributor

facebook-github-bot commented Mar 20, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia pushed a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

12d78d3

Summary:
Pull Request resolved: pytorch#2170

bypass-github-export-checks

Differential Revision: https://internalfb.com/D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

626ea64

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from a7eb3a2 to 626ea64 Compare

March 20, 2024 23:50

Contributor

facebook-github-bot commented Mar 20, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Gasoonjia pushed a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

3ce7d2a

Summary:
Pull Request resolved: pytorch#2170

bypass-github-export-checks

Differential Revision: https://internalfb.com/D54341919

Gasoonjia pushed a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

0c184b0

Summary:
Pull Request resolved: pytorch#2170

bypass-github-export-checks

Differential Revision: https://internalfb.com/D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

903bece

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

c732de6

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

a21c642

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai

Differential Revision: D54341919

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

03d9c87

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai

Differential Revision: D54341919

larryliu0820 approved these changes

View reviewed changes

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request


          directly using dim order for memory format comparsion. (pytorch#2170)

d88b4a9

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai, larryliu0820

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from 626ea64 to d88b4a9 Compare

March 22, 2024 19:26

Contributor

facebook-github-bot commented Mar 22, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

Songhao Jia and others added 3 commits

March 22, 2024 16:44


          make utils support empty dim order (pytorch#2142)

cb38cef

Summary:
Pull Request resolved: pytorch#2142

This update makes util function support empty dim order, to make the empty dim order behave the same as empty memory format (preserve_format).
bypass-github-export-checks

Differential Revision: https://www.internalfb.com/diff/D54236386?entry_point=27


          rename default dim order as contiguous dim order (pytorch#2157)

d1e04f6

Summary:
Pull Request resolved: pytorch#2157

bypass-github-export-checks

Differential Revision: https://internalfb.com/D54285070


          directly using dim order for memory format comparsion. (pytorch#2170)

5c1c572

Summary: Pull Request resolved: pytorch#2170

Reviewed By: digantdesai, larryliu0820

Differential Revision: D54341919

Gasoonjia force-pushed the export-D54341919 branch from d88b4a9 to 5c1c572 Compare

March 22, 2024 23:46

Contributor

facebook-github-bot commented Mar 22, 2024

This pull request was exported from Phabricator. Differential Revision: D54341919

facebook-github-bot closed this in

1899be4

Contributor

facebook-github-bot commented Mar 24, 2024

This pull request has been merged in 1899be4.

facebook-github-bot added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged