Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executorch][threadpool] Add "private" method to reset num threads in threadpool #2351

Closed
wants to merge 9 commits into from

Conversation

kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Mar 11, 2024

Stack from ghstack (oldest at bottom):

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: D54766070

… threadpool

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2351

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ee0267c with merge base e98a7e0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Mar 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

… threads in threadpool"

This diff introduces new API to reset threadpool. This will be short-lived
features. It is needed atm because we dont have a) a way to use only a subset of
threads to distribute work in the threadpool and b) API to create threadpool of
custom size and pass such a threadpool to backends like delegtes, cusotm ops,
optimized cpu op lib etc.

Differential Revision: [D54766070](https://our.internmc.facebook.com/intern/diff/D54766070/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54766070

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 86b9ff7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants